Skip to content

Comments

feat: sealed secret namespace endpoints#925

Open
dennisvankekem wants to merge 6 commits intomainfrom
APL-1469
Open

feat: sealed secret namespace endpoints#925
dennisvankekem wants to merge 6 commits intomainfrom
APL-1469

Conversation

@dennisvankekem
Copy link
Contributor

@dennisvankekem dennisvankekem commented Feb 19, 2026

@dennisvankekem dennisvankekem marked this pull request as ready for review February 24, 2026 09:43
description: Namspace to write file under in manifest
required: true
schema:
type: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a pattern for the namespace parameter. (e.g '^[a-z0-9-]+$')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see that happening anywhere else in the components parameters. Is this the right place to do so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes then then openapi validator will validate it. We indeed do not have it in a lot of places. But we should start doing it for request parameters. So we prevent injections vulnerabilities. In this case an injection will not do much, but we should start getting a habit of preventing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we used this here as an example, but not below in the file general parameters section. However, I think it’s also fine to use it below in the parameters as pattern: '^[a-z0-9-]+$'. We have a validator in the console, but it would also be good to have it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants