Conversation
| description: Namspace to write file under in manifest | ||
| required: true | ||
| schema: | ||
| type: string |
There was a problem hiding this comment.
I think we should add a pattern for the namespace parameter. (e.g '^[a-z0-9-]+$')
There was a problem hiding this comment.
i don't see that happening anywhere else in the components parameters. Is this the right place to do so?
There was a problem hiding this comment.
Yes then then openapi validator will validate it. We indeed do not have it in a lot of places. But we should start doing it for request parameters. So we prevent injections vulnerabilities. In this case an injection will not do much, but we should start getting a habit of preventing it.
There was a problem hiding this comment.
It seems we used this here as an example, but not below in the file general parameters section. However, I think it’s also fine to use it below in the parameters as pattern: '^[a-z0-9-]+$'. We have a validator in the console, but it would also be good to have it here.
console linode/apl-console#726